Improve test coverage: pkg/api/persistentvolume #107159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
@mengjiao-liu: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-priority
|
/sig testing |
k8s-ci-robot
added
sig/testing
mengjiao-liu
changed the title
mengjiao-liu
force-pushed
the
improve-unit-test-coverage-pv
branch
from
bb07294
to
250058d
Compare
mengjiao-liu
changed the title
mengjiao-liu
force-pushed
the
improve-unit-test-coverage-pv
branch
from
250058d
to
7319114
Compare
|
/test pull-kubernetes-node-e2e-containerd |
|
/assign @thockin |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve
…On Tue, Jan 4, 2022 at 8:41 PM Kubernetes Prow Robot < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *mengjiao-liu
<#107159#>*, *msau42
<#107159 (comment)>*
To complete the pull request process
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>,
please ask for approval from *thockin* after the PR has been reviewed.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes>.
Needs approval from an approver in each of these files:
- *pkg/api/OWNERS
<https://github.com/kubernetes/kubernetes/blob/master/pkg/api/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
Reply to this email directly, view it on GitHub
<#107159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVCGNLP7GTAVPKUBGMDUUPDZNANCNFSM5KPXFNPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mengjiao-liu, msau42, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
improve test coverage pkg/api/persistentvolume/util_test.go from 87.5% to 100%.
The original test cases did not cover the condition of disabled
ExpandCSIVolumesfeature gate and no secrets, resulting in the following line of code not being covered.kubernetes/pkg/api/persistentvolume/util.go
Line 43 in 13e9745
Test coverage before modifying the code:
go test -cover ./pkg/api/persistentvolume/... ok k8s.io/kubernetes/pkg/api/persistentvolume (cached) coverage: 87.5% of statementsTest coverage after modifying the code:
Which issue(s) this PR fixes:
Ref #97355
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: